Re: [PATCH v3 0/2] Amazon's Annapurna Labs Fabric Interrupt Controller
From: Marc Zyngier
Date: Wed Jun 05 2019 - 11:20:53 EST
On 05/06/2019 15:59, Talel Shenhar wrote:
> This series introduces support for Amazon's Annapurna Labs Fabric Interrupt
> Controller.
>
> The Amazon's Annapurna Labs FIC (Fabric Interrupt Controller) has 32
> inputs/sources. This FIC may be cascaded into another FIC or connected
> directly to the main CPU Interrupt Controller (e.g. GIC).
>
> Changes since v2:
> =================
> - updated dt-bindings to use proper format for entry name
> - removed kernel-doc format style from Copyright
> - removed unneeded/misplaced selects from Kconfig
> - changed used mmio operation to relaxed flavor
> - changed error return value from EPERM to EINVAL int case of attempting to
> reconfigure the FIC after it has been configured
> - fixed commenting format
> - used drivers define instead of subsystem internals
> - moved al_fic_hw_init function to caller
> - removed al_fic_wire_get_domain from documentation
> - removed argument validation from al_fic_wire_init
>
> Changes since v1:
> =================
> - removing unused exported APIs
> - updating cover letter and commit message accordingly
>
>
>
> Talel Shenhar (2):
> dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC
> irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt
> Controller Driver
>
> .../interrupt-controller/amazon,al-fic.txt | 22 ++
> MAINTAINERS | 6 +
> drivers/irqchip/Kconfig | 8 +
> drivers/irqchip/Makefile | 1 +
> drivers/irqchip/irq-al-fic.c | 278 +++++++++++++++++++++
> 5 files changed, 315 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt
> create mode 100644 drivers/irqchip/irq-al-fic.c
>
OK, that's 3 version in about 8 hours, I'm simply going to ignore it
(you'll need to post a v4 anyway). Please see
Documentation/process/submitting-patches.rst, specifically points (8)
and (9).
M.
--
Jazz is not dead. It just smells funny...