Re: [PATCH] USB: sisusbvga: Remove unneeded variable

[Greg Kroah-Hartman]

On Wed, Jun 05, 2019 at 10:49:08PM +0530, Hariprasad Kelam wrote:
> fix below warning reported by coccicheck
> 
> drivers/usb/misc/sisusbvga/sisusb.c:1753:5-8: Unneeded variable: "ret".
> Return "0" on line 1877
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx>
> ---
>  drivers/usb/misc/sisusbvga/sisusb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
> index ea06f1f..dfe2ed1 100644
> --- a/drivers/usb/misc/sisusbvga/sisusb.c
> +++ b/drivers/usb/misc/sisusbvga/sisusb.c
> @@ -1750,7 +1750,7 @@ static int sisusb_setup_screen(struct sisusb_usb_data *sisusb,
>  static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
>  		int touchengines)
>  {
> -	int ret = 0, i, j, modex, bpp, du;
> +	int i, j, modex, bpp, du;
>  	u8 sr31, cr63, tmp8;
>  	static const char attrdata[] = {
>  		0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
> @@ -1874,7 +1874,7 @@ static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
>  
>  	SETIREG(SISCR, 0x34, 0x44);	/* we just set std mode #44 */
>  
> -	return ret;
> +	return 0;

If this function can not fail, why is it returning anything at all?
Please fix that up at the same time.

thanks,

greg k-h