Re: [PATCH 5/7] media: cedrus: Don't set chroma size for scale & rotation

From: Paul Kocialkowski
Date: Wed Jun 05 2019 - 17:12:19 EST


Hi,

Le jeudi 30 mai 2019 Ã 23:15 +0200, Jernej Skrabec a Ãcrit :
> Scale and rotation are currently not implemented, so it makes no sense to
> set chroma size for it.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>

Acked-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>
Cheers,

Paul

> ---
> drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> index 9c5819def186..9de20ae47916 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> @@ -79,9 +79,6 @@ void cedrus_dst_format_set(struct cedrus_dev *dev,
> reg = VE_PRIMARY_OUT_FMT_NV12;
> cedrus_write(dev, VE_PRIMARY_OUT_FMT, reg);
>
> - reg = VE_CHROMA_BUF_LEN_SDRT(chroma_size / 2);
> - cedrus_write(dev, VE_CHROMA_BUF_LEN, reg);
> -
> reg = chroma_size / 2;
> cedrus_write(dev, VE_PRIMARY_CHROMA_BUF_LEN, reg);
>