Re: [PATCH V3 1/2] zpool: Add malloc_support_movable to zpool_driver

From: Vitaly Wool
Date: Wed Jun 05 2019 - 20:28:40 EST


Hi Shakeel,

On Wed, Jun 5, 2019 at 6:31 PM Shakeel Butt <shakeelb@xxxxxxxxxx> wrote:
>
> On Wed, Jun 5, 2019 at 3:06 AM Hui Zhu <teawaterz@xxxxxxxxxxxxxxxxx> wrote:
> >
> > As a zpool_driver, zsmalloc can allocate movable memory because it
> > support migate pages.
> > But zbud and z3fold cannot allocate movable memory.
> >
>
> Cc: Vitaly

thanks for looping me in :)

> It seems like z3fold does support page migration but z3fold's malloc
> is rejecting __GFP_HIGHMEM. Vitaly, is there a reason to keep
> rejecting __GFP_HIGHMEM after 1f862989b04a ("mm/z3fold.c: support page
> migration").

No; I don't think I see a reason to keep that part. You are very
welcome to submit a patch, or otherwise I can do it when I'm done with
the patches that are already in the pipeline.

Thanks,
Vitaly