Re: [PATCH v2 4/7] perf diff: Use hists to manage basic blocks per symbol

From: Jin, Yao
Date: Wed Jun 05 2019 - 21:19:16 EST

On 6/5/2019 7:44 PM, Jiri Olsa wrote:
On Mon, Jun 03, 2019 at 10:36:14PM +0800, Jin Yao wrote:


diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index 43623fa..d1641da 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -79,6 +79,9 @@ struct hist_entry_diff {
s64 wdiff;
+ s64 cycles;
@@ -143,6 +146,9 @@ struct hist_entry {
struct branch_info *branch_info;
long time;
struct hists *hists;
+ void *block_hists;
+ int block_idx;
+ int block_num;
struct mem_info *mem_info;
struct block_info *block_info;

could you please not add the new block* stuff in here,
and instead use the "c2c model" and use yourr own struct
on top of hist_entry? we are trying to librarize this
stuff and keep only necessary things in here..

you're already using hist_entry_ops, so should be easy

something like:

struct block_hist_entry {
void *block_hists;
int block_idx;
int block_num;
struct block_info *block_info;

struct hist_entry he;


Oh, yes, I should refer to 'c2c_hist_entry'. That avoids to add more stuffs in hist_entry. That's a good idea!

Jin Yao