Re: [PATCH v2 4/7] perf diff: Use hists to manage basic blocks per symbol

[Jin, Yao]

On 6/5/2019 7:44 PM, Jiri Olsa wrote:
> On Mon, Jun 03, 2019 at 10:36:14PM +0800, Jin Yao wrote:
>
> SNIP
>
> >   					   sort_compute);
> >   }
> >   
> > +static int64_t
> > +hist_entry__cmp_cycles_idx(struct perf_hpp_fmt *fmt __maybe_unused,
> > +			   struct hist_entry *left __maybe_unused,
> > +			   struct hist_entry *right __maybe_unused)
> > +{
> > +	return 0;
> > +}
> > +
> >   static void hists__process(struct hists *hists)
> >   {
> >   	if (show_baseline_only)
> > @@ -746,6 +930,8 @@ static void data_process(void)
> >   	struct perf_evsel *evsel_base;
> >   	bool first = true;
> >   
> > +	memset(&dummy_al, 0, sizeof(dummy_al));
>
> why is this needed? it's zero by static declaration, and it's never set, right?
>
> jirka

C standard says yes for initializing static variables to 0, but I just 
want to avoid any potential for unexpected behavior. Maybe I was over 
thinking it. I will remove this line.

Thanks
Jin Yao