Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects

[Bitan Biswas]

On 5/31/19 5:45 AM, Dmitry Osipenko wrote:
> 31.05.2019 12:04, Bitan Biswas ÐÐÑÐÑ:
> > On 5/30/19 4:43 AM, Dmitry Osipenko wrote:
> > > 30.05.2019 14:36, Dmitry Osipenko ÐÐÑÐÑ:
> > > > 30.05.2019 9:14, Bitan Biswas ÐÐÑÐÑ:
> > > > > Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
> > > > > except for BUG/BUG_ON checks
> > > >
> > > > Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire,
> > > > hence there is absolutely no good reason in making system unusable on a
> > > > software bug. BUG_ON may be more useful for development, but not for a
> > > > casual daily usage.
> > I shall update the patch to remove the BUG/BUG_ON calls.
>
> Please replace them with WARN_ON_ONCE.
Based on review of the BUG_ON some were found redundant calls and hence 
planned to be removed. Non-trivial BUG_ON planned to be replaced with 
WARN_ON_ONCE call.

-regards,
 Bitan