Re: [PATCH 12/16] mm: consolidate the get_user_pages* implementations

[John Hubbard]

On 6/5/19 11:20 PM, Christoph Hellwig wrote:
> On Wed, Jun 05, 2019 at 11:01:17PM -0700, John Hubbard wrote:
> > I started reviewing this one patch, and it's kind of messy figuring out
> > if the code motion preserves everything because of
> > all the consolidation from other places, plus having to move things in
> > and out of the ifdef blocks.  So I figured I'd check and see if this is
> > going to make it past RFC status soon, and if it's going before or after
> > Ira's recent RFC ("RDMA/FS DAX truncate proposal").
>
> I don't like the huge moves either, but I can't really think of any
> better way to do it.  Proposals welcome, though.

One way would be to do it in two patches:

1) Move the code into gup.c, maybe at the bottom. Surround each function
or group of functions by whatever ifdefs they need.

2) Move code out of the bottom of gup.c, into the final location.

...but I'm not certain that will be that much better. In the spirit of
not creating gratuitous work for others, I could try it out and send
out something if it looks like it's noticeably easier to verify/review.

thanks,
--
John Hubbard
NVIDIA