Re: [PATCH 02/13] bus_find_device: Unify the match callback with class_find_device

[Srinivas Kandagatla]

On 05/06/2019 16:13, Suzuki K Poulose wrote:
> There is an arbitrary difference between the prototypes of
> bus_find_device() and class_find_device() preventing their callers
> from passing the same pair of data and match() arguments to both of
> them, which is the const qualifier used in the prototype of
> class_find_device().  If that qualifier is also used in the
> bus_find_device() prototype, it will be possible to pass the same
> match() callback function to both bus_find_device() and
> class_find_device(), which will allow some optimizations to be made in
> order to avoid code duplication going forward.  Also with that, constify
> the "data" parameter as it is passed as a const to the match function.
>
> For this reason, change the prototype of bus_find_device() to match
> the prototype of class_find_device() and adjust its callers to use the
> const qualifier in accordance with the new prototype of it.
>
> Cc: Alexander Shishkin<alexander.shishkin@xxxxxxxxxxxxxxx>
> Cc: Andrew Lunn<andrew@xxxxxxx>
> Cc: Andreas Noever<andreas.noever@xxxxxxxxx>
> Cc: Arnd Bergmann<arnd@xxxxxxxx>
> Cc: Bjorn Helgaas<bhelgaas@xxxxxxxxxx>
> Cc: Corey Minyard<minyard@xxxxxxx>
> Cc: Christian Borntraeger<borntraeger@xxxxxxxxxx>
> Cc: David Kershner<david.kershner@xxxxxxxxxx>
> Cc: "David S. Miller"<davem@xxxxxxxxxxxxx>
> Cc: David Airlie<airlied@xxxxxxxx>
> Cc: Felipe Balbi<balbi@xxxxxxxxxx>
> Cc: Frank Rowand<frowand.list@xxxxxxxxx>
> Cc: Grygorii Strashko<grygorii.strashko@xxxxxx>
> Cc: Harald Freudenberger<freude@xxxxxxxxxxxxx>
> Cc: Hartmut Knaack<knaack.h@xxxxxx>
> Cc: Heiko Stuebner<heiko@xxxxxxxxx>
> Cc: Jason Gunthorpe<jgg@xxxxxxxx>
> Cc: Jonathan Cameron<jic23@xxxxxxxxxx>
> Cc: Jonathan Cameron<jic23@xxxxxxxxxx>
> Cc: "James E.J. Bottomley"<jejb@xxxxxxxxxxxxx>
> Cc: Len Brown<lenb@xxxxxxxxxx>
> Cc: Mark Brown<broonie@xxxxxxxxxx>
> Cc: Michael Ellerman<mpe@xxxxxxxxxxxxxx>
> Cc: Michael Jamet<michael.jamet@xxxxxxxxx>
> Cc: "Martin K. Petersen"<martin.petersen@xxxxxxxxxx>
> Cc: Peter Oberparleiter<oberpar@xxxxxxxxxxxxx>
> Cc: Rob Herring<robh+dt@xxxxxxxxxx>
> Cc: Sebastian Ott<sebott@xxxxxxxxxxxxx>
> Cc: Srinivas Kandagatla<srinivas.kandagatla@xxxxxxxxxx>
> Cc: Yehezkel Bernat<YehezkelShB@xxxxxxxxx>
> Cc: Wolfram Sang<wsa@xxxxxxxxxxxxx>
> Cc:rafael@xxxxxxxxxx
> Cc: Greg Kroah-Hartman<gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Suzuki K Poulose<suzuki.poulose@xxxxxxx>
> ---
>   arch/powerpc/platforms/pseries/ibmebus.c           | 4 ++--
>   drivers/acpi/acpi_lpss.c                           | 4 ++--
>   drivers/acpi/sleep.c                               | 2 +-
>   drivers/acpi/utils.c                               | 4 ++--
>   drivers/base/bus.c                                 | 6 +++---
>   drivers/base/devcon.c                              | 2 +-
>   drivers/char/ipmi/ipmi_si_platform.c               | 2 +-
>   drivers/firmware/efi/dev-path-parser.c             | 4 ++--
>   drivers/gpu/drm/drm_mipi_dsi.c                     | 2 +-
>   drivers/hwtracing/coresight/coresight.c            | 6 +++---
>   drivers/hwtracing/coresight/of_coresight.c         | 2 +-
>   drivers/hwtracing/intel_th/core.c                  | 5 ++---
>   drivers/i2c/i2c-core-acpi.c                        | 4 ++--
>   drivers/i2c/i2c-core-of.c                          | 4 ++--
>   drivers/iio/inkern.c                               | 2 +-
>   drivers/infiniband/hw/hns/hns_roce_hw_v1.c         | 2 +-
>   drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
>   drivers/net/ethernet/ti/cpsw-phy-sel.c             | 4 ++--
>   drivers/net/ethernet/ti/davinci_emac.c             | 2 +-
>   drivers/net/ethernet/toshiba/tc35815.c             | 4 ++--
>   drivers/nvmem/core.c                               | 2 +-


For NVMEM changes,

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>


--srini