Re: [PATCH 4.19 163/276] mmc: core: make pwrseq_emmc (partially) support sleepy GPIO controllers

[Pavel Machek]

Hi!

(stable removed from cc list)

>  static void mmc_pwrseq_emmc_reset(struct mmc_host *host)
>  {
>  	struct mmc_pwrseq_emmc *pwrseq =  to_pwrseq_emmc(host->pwrseq);
>  
> -	__mmc_pwrseq_emmc_reset(pwrseq);
> +	gpiod_set_value_cansleep(pwrseq->reset_gpio, 1);
> +	udelay(1);
> +	gpiod_set_value_cansleep(pwrseq->reset_gpio, 0);
> +	udelay(200);
>  }
>  

If we can sleep here, does it make sense to use *sleep() here?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature