Re: [PATCH 01/20] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation

From: Laurent Pinchart
Date: Thu Jun 06 2019 - 12:56:31 EST


Hi Jacopo,

Thank you for the patch.

On Thu, Jun 06, 2019 at 04:22:01PM +0200, Jacopo Mondi wrote:
> Add device tree bindings documentation for the Renesas R-Car Display
> Unit Color Management Module.
>
> CMM is the image enhancement module available on each R-Car DU video
> channel on Gen2 and Gen3 SoCs (V3H and V3M excluded).
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> .../bindings/display/renesas,cmm.txt | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.txt
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.txt b/Documentation/devicetree/bindings/display/renesas,cmm.txt
> new file mode 100644
> index 000000000000..d8d3cf9ce2ce
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt
> @@ -0,0 +1,25 @@
> +* Renesas R-Car Color Management Module (CMM)
> +
> +Renesas R-Car image enhancement module connected to R-Car DU video channels.
> +
> +Required properties:
> + - compatible: shall be one of:
> + - "renesas,cmm-gen3"
> + - "renesas,cmm-gen2"
> +
> + - reg: the address base and length of the memory area where CMM control
> + registers are mapped to.
> +
> + - clocks: phandle and clock-specifier pair to the CMM functional clock
> + supplier.
> +
> +Example:
> +--------
> +
> + cmm0: cmm@fea40000 {
> + compatible = "renesas,cmm";
> + reg = <0 0xfea40000 0 0x1000>;
> + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> + clocks = <&cpg CPG_MOD 711>;
> + resets = <&cpg 711>;
> + };

--
Regards,

Laurent Pinchart