Re: [PATCH] clk: qcom: clk-rpm: Removed unused macros/variable

From: Stephen Boyd
Date: Thu Jun 06 2019 - 13:36:42 EST


Quoting Philippe Mazenauer (2019-05-21 02:45:25)
> Removed macros DEFINE_CLK_RPM_PXO_BRANCH, DEFINE_CLK_RPM_CXO_BRANCH and
> variable 'clk_rpm_branch_ops'. The macros and variable are not used in the
> file.
>
> As the variable, which is used by the macros, is declared static, the
> macros can't be used outside the file, are unused.
>
> ../drivers/clk/qcom/clk-rpm.c:461:29: warning: âclk_rpm_branch_opsâ defined but not used [-Wunused-const-variable=]
> static const struct clk_ops clk_rpm_branch_ops = {
> ^~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@xxxxxxxxxx>

Yeah it's dead code but the qcom folks wanted to manage the crystal with
this code so maybe we should just leave it around for them. Or they
could dig it out of the git history.