Re: [PATCH 2/2] drm/meson: fix G12A primary plane disabling

[Neil Armstrong]

On 06/06/2019 19:30, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@xxxxxxxxxxxx> writes:
> 
>> The G12A Primary plane was disabled by writing in the OSD1 configuration
>> registers, but this caused the plane blender to stall instead of continuing
>> blended only the overlay plane.
> 
> grammar nit: "...instead of continuing to blend only the overlay plane."

Fixed while applying on drm-misc-fixes

> 
>> Fix this by disabling the OSD1 plane in the blender registers, and also
>> enabling it back using the same register.
>>
>> Fixes: 490f50c109d1 ("drm/meson: Add G12A support for OSD1 Plane")
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> 
> Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
> 
> As noted elsewhere, this driver is also full of magic constants used in
> register writes which makes reviewing this kind of change for
> correctness that much more difficult, but since that's already been
> pointed out elsewhere, and it's already on your TODO list, it should not
> block this important fix.

Yep, it's the top priority now.

Thanks,

Neil

> 
> Kevin
>