Re: [PATCH V8 13/15] phy: tegra: Add PCIe PIPE2UPHY support

[Vidya Sagar]

On 6/6/2019 10:00 PM, Dmitry Osipenko wrote:
> 26.05.2019 7:37, Vidya Sagar ÐÐÑÐÑ:
> > Synopsys DesignWare core based PCIe controllers in Tegra 194 SoC interface
> > with Universal PHY (UPHY) module through a PIPE2UPHY (P2U) module.
> > For each PCIe lane of a controller, there is a P2U unit instantiated at
> > hardware level. This driver provides support for the programming required
> > for each P2U that is going to be used for a PCIe controller.
> >
> > Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
> > ---
> > Changes since [v7]:
> > * Changed P2U driver file name from pcie-p2u-tegra194.c to phy-tegra194-p2u.c
> >
> > Changes since [v6]:
> > * None
> >
> > Changes since [v5]:
> > * Addressed review comments from Thierry
> >
> > Changes since [v4]:
> > * None
> >
> > Changes since [v3]:
> > * Rebased on top of linux-next top of the tree
> >
> > Changes since [v2]:
> > * Replaced spaces with tabs in Kconfig file
> > * Sorted header file inclusion alphabetically
> >
> > Changes since [v1]:
> > * Added COMPILE_TEST in Kconfig
> > * Removed empty phy_ops implementations
> > * Modified code according to DT documentation file modifications
> >
> >   drivers/phy/tegra/Kconfig            |   7 ++
> >   drivers/phy/tegra/Makefile           |   1 +
> >   drivers/phy/tegra/phy-tegra194-p2u.c | 109 +++++++++++++++++++++++++++
> >   3 files changed, 117 insertions(+)
> >   create mode 100644 drivers/phy/tegra/phy-tegra194-p2u.c
> >
> > diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig
> > index a3b1de953fb7..c56fc8452e03 100644
> > --- a/drivers/phy/tegra/Kconfig
> > +++ b/drivers/phy/tegra/Kconfig
> > @@ -6,3 +6,10 @@ config PHY_TEGRA_XUSB
> >   
> >   	  To compile this driver as a module, choose M here: the module will
> >   	  be called phy-tegra-xusb.
> > +
> > +config PHY_TEGRA194_P2U
> > +	tristate "NVIDIA Tegra194 PIPE2UPHY PHY driver"
> > +	depends on ARCH_TEGRA || COMPILE_TEST
>
> ARCH_TEGRA is a bit too much, ARCH_TEGRA_194_SOC should fit better here.
Ok. I'll take care of it in the next patch series.