Re: [PATCH] KVM: VMX: simplify vmx_prepare_switch_to_{guest,host}

From: Paolo Bonzini
Date: Fri Jun 07 2019 - 14:17:41 EST


On 07/06/19 19:47, Sean Christopherson wrote:
>> This is the hiccup with naming it sregs_loaded. The split bools is also
>> kinda wonky since the 32->64 case is a one-off scenario. I think a
>> cleaner solution would be to remove guest_msrs_dirty and refresh the MSRs
>> directly from setup_msrs(). Then loaded_cpu_state -> loaded_guest_state
>> can be a straight conversion from loaded_vmcs -> bool. I'll send patches.
> Actually, would it be easier on your end if I do a v2 of the series that
> would introduce vmx_sync_vmcs_host_state(), and splice these patch into it?

For now I'll just rename it to guest_state_loaded, let's do further
cleanups on top. My plan is to post my version of everything after
testing so that you can do a "git range-diff" between my patches and
yours. (For exposure I'll probably push that to kvm/queue, but I don't
intend to merge them to kvm/next without your review).

Paolo