Re: [PATCH v4 0/6] MSM8998 Multimedia Clock Controller

From: Stephen Boyd
Date: Fri Jun 07 2019 - 16:42:55 EST


Quoting Jeffrey Hugo (2019-05-21 07:52:28)
> On 5/21/2019 8:44 AM, Jeffrey Hugo wrote:
> > The multimedia clock controller (mmcc) is the main clock controller for
> > the multimedia subsystem and is required to enable things like display and
> > camera.
>
> Stephen, I think this series is good to go, and I have display/gpu stuff
> I'm polishing that will depend on this. Would you kindly pickup patches
> 1, 3, 4, and 5 for 5.3? I can work with Bjorn to pick up patches 2 and 6.
>

If I apply patch 3 won't it break boot until patch 2 is also in the
tree? That seems to imply that I'll break bisection, and we have
kernelci boot testing clk-next so this will probably set off alarms
somewhere.

I thought we had some code that got removed that was going to make the
transition "seamless" in the sense that it would search the tree for an
RPM clk controller and then not add the XO fixed factor clk somehow.
See commit 54823af9cd52 ("clk: qcom: Always add factor clock for xo
clocks") for the code that we removed. So ideally we do something like
this too, but now we search for a property on the calling node to see if
the XO clk is there?