Re: [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN

From: Linus Walleij
Date: Fri Jun 07 2019 - 17:08:53 EST


On Thu, May 30, 2019 at 5:04 AM <Anson.Huang@xxxxxxx> wrote:

> From: Anson Huang <Anson.Huang@xxxxxxx>
>
> Add binding doc for i.MX8MN pinctrl driver.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>

Looks mostly OK to me, but I'd like the maintainers to review,
so Dong et al please look at this!

> +Required properties:
> +- compatible: "fsl,imx8mn-iomuxc"

So should this not be "nxp,imx8mn-iomuxc"
or "nxp,freescale-imx8mn-iomuxc" or something these
days? The vendor name is nxp is it not.

I was complaining to the DT maintainers at one point that
these companies seem to buy each other left and right
so this vendor nomenclature is dubious, but I guess at least
it should reflect the vendor that produced the chip or something.

If everyone is happy with "fsl,*" I will not complain though.
(i.e. if the maintainers ACK it.)

Yours,
Linus Walleij