[PATCH AUTOSEL 5.1 29/70] io_uring: Fix __io_uring_register() false success

From: Sasha Levin
Date: Sat Jun 08 2019 - 07:58:19 EST


From: Pavel Begunkov <asml.silence@xxxxxxxxx>

[ Upstream commit a278682dad37fd2f8d2f30d8e84e376a856ab472 ]

If io_copy_iov() fails, it will break the loop and report success,
albeit partially completed operation.

Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx>
Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 30a5687a17b6..69ff94558758 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2505,7 +2505,7 @@ static int io_sqe_buffer_register(struct io_ring_ctx *ctx, void __user *arg,

ret = io_copy_iov(ctx, &iov, arg, i);
if (ret)
- break;
+ goto err;

/*
* Don't impose further limits on the size and buffer
--
2.20.1