Re: [PATCH] Staging: rts5208: fixed brace coding style issue

From: Greg KH
Date: Sat Jun 08 2019 - 11:58:45 EST


On Sat, Jun 08, 2019 at 03:53:35PM +0200, xabi1500@xxxxxxxxx wrote:
> From: Xabier Etxezarreta <xabi1500@xxxxxxxxx>
>
> Fixed a coding style issue checked with checkpatch.pl
>
> Signed-off-by: Xabier Etxezarreta <xabi1500@xxxxxxxxx>
> ---
> drivers/staging/rts5208/rtsx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index fa597953e9a0..d16e92b09a1f 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -419,10 +419,7 @@ static int rtsx_control_thread(void *__dev)
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> chip->srb->result = DID_BAD_TARGET << 16;
> - }
> -
> - /* we've got a command, let's do it! */
> - else {
> + } else { /* we've got a command, let's do it! */
> scsi_show_command(chip);

Comment should go on a new line.

thanks,

greg k-h