Re: [PATCH AUTOSEL 5.1 058/186] tracing: probeevent: Fix to make the type of $comm string

[Sasha Levin]

On Sat, Jun 08, 2019 at 05:31:13PM -0400, Steven Rostedt wrote:
> On Sat,  1 Jun 2019 09:14:34 -0400
> Sasha Levin <sashal@xxxxxxxxxx> wrote:
>
> > From: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> >
> > [ Upstream commit 3dd1f7f24f8ceec00bbbc364c2ac3c893f0fdc4c ]
> >
> > Fix to make the type of $comm "string".  If we set the other type to $comm
> > argument, it shows meaningless value or wrong data. Currently probe events
> > allow us to set string array type (e.g. ":string[2]"), or other digit types
> > like x8 on $comm. But since clearly $comm is just a string data, it should
> > not be fetched by other types including array.
> >
> > Link: http://lkml.kernel.org/r/155723736241.9149.14582064184468574539.stgit@devnote2
> >
> > Cc: Andreas Ziegler <andreas.ziegler@xxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
>
> I thought the "AUTOSEL" patches are to find patches that are not marked
> for stable and pull them in. It would be good to differentiate those in
> the subject. As I'm more inclined to audit automatically pulled in ones,
> because those are more likely to be incorrectly backported.

That's indeed the case. I had some experimental changes for this merge
window and apparently some stable tagged patches ended up sneaking in.
Sorry about that!.

--
Thanks,
Sasha