Re: [PATCH 3/8] pinctrl: msm: Add ability for drivers to supply a reserved GPIO list
From: Lee Jones
Date: Mon Jun 10 2019 - 04:01:56 EST
On Fri, 07 Jun 2019, Bjorn Andersson wrote:
> On Fri 07 Jun 16:02 PDT 2019, Linus Walleij wrote:
>
> > On Wed, Jun 5, 2019 at 1:43 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> >
> > > When booting MSM based platforms with Device Tree or some ACPI
> > > implementations, it is possible to provide a list of reserved pins
> > > via the 'gpio-reserved-ranges' and 'gpios' properties respectively.
> > > However some ACPI tables are not populated with this information,
> > > thus it has to come from a knowledgable device driver instead.
> > >
> > > Here we provide the MSM common driver with additional support to
> > > parse this informtion and correctly populate the widely used
> > > 'valid_mask'.
> > >
> > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> >
> > Exactly how we should use of the API, so if BjÃrn can supply an
> > ACK to patches 3 and 4 I'm happy to apply them.
> >
> > BjÃrn?
> >
>
> I'm waiting for a version that does not specify the reserved_gpios for
> struct msm_pinctrl_soc_data sdm845_pinctrl {}, as this would override
> the ability of getting these from DT.
>
> I haven't seen such revision yet, will review it once I find it.
Just testing it now. It should be on the list by the time you start.
--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog