Re: [RFC PATCH 5/6] dt-bindings: soundwire: add bindings for Qcom controller

[Srinivas Kandagatla]

On 10/06/2019 05:51, Vinod Koul wrote:
> On 07-06-19, 09:56, Srinivas Kandagatla wrote:
> > This patch adds bindings for Qualcomm soundwire controller.
> >
> > Qualcomm SoundWire Master controller is present in most Qualcomm SoCs
> > either integrated as part of WCD audio codecs via slimbus or
> > as part of SOC I/O.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
> >   .../bindings/soundwire/qcom,swr.txt           | 62 +++++++++++++++++++
>
> So I was expecting to see bus support patches for OF first. I think you
> have missed those changes. Please do include those in v2 with bindings
> and OF support for bus.

I was planning to post bus bindings along with soundwire slave bindings 
of WSA881x driver!
I will be sending this soon!

> >   1 file changed, 62 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/soundwire/qcom,swr.txt
> >
> > diff --git a/Documentation/devicetree/bindings/soundwire/qcom,swr.txt b/Documentation/devicetree/bindings/soundwire/qcom,swr.txt
> > new file mode 100644
> > index 000000000000..eb84d0f4f36f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soundwire/qcom,swr.txt
> > @@ -0,0 +1,62 @@
> > +Qualcomm SoundWire Controller
> > +
> > +This binding describes the Qualcomm SoundWire Controller Bindings.
> > +
> > +Required properties:
> > +
> > +- compatible:		Must be "qcom,soundwire-v<MAJOR>.<MINOR>.<STEP>",
> > +	 		example:
> > +			"qcom,soundwire-v1.3.0"
> > +			"qcom,soundwire-v1.5.0"
> > +			"qcom,soundwire-v1.6.0"
> > +- reg:			SoundWire controller address space.
> > +- interrupts:		SoundWire controller interrupt.
> > +- clock-names:		Must contain "iface".
> > +- clocks:		Interface clocks needed for controller.
> > +- #sound-dai-cells:	Must be 1 for digital audio interfaces on the controllers.
> > +- #address-cells:	Must be 1 for SoundWire devices;
> > +- #size-cells:		Must be <0> as SoundWire addresses have no size component.
> > +- qcom,dout-ports: 	Must be count of data out ports
> > +- qcom,din-ports: 	Must be count of data in ports
>
> On these I think we should have specified dpn properties as specified in
> DisCo, but then looking at spec we do not define that for master, but
> bus seems to have it.
>
> Pierre do you why master does not have dpn properties in DisCo?
>
> > +- qcom,ports-offset1:	Must be frame offset1 of each data port.
> > +			Out followed by In. Used for Block size calculation.
> > +- qcom,ports-offset2: 	Must be frame offset2 of each data port.
> > +			Out followed by In. Used for Block size calculation.
> > +- qcom,ports-sinterval-low: Must be sample interval low of each data port.
> > +			Out followed by In. Used for Sample Interval calculation.
>
> These are software so do not belong here
These are board-specfic properties w.r.t this controller ports 
configuration.
I don't see any other option to specify this?
Do you have any alternative suggestions?

--srini
>