Re: [PATCH 0/8] fix warnings for same module names

From: Anders Roxell
Date: Mon Jun 10 2019 - 09:02:56 EST


On Thu, 6 Jun 2019 at 12:11, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote:
>
> Em Thu, 6 Jun 2019 11:46:57 +0200
> Anders Roxell <anders.roxell@xxxxxxxxxx> escreveu:
>
> > Hi,
> >
> > This patch set addresses warnings that module names are named the
> > same, this may lead to a problem that wrong module gets loaded or if one
> > of the two same-name modules exports a symbol, this can confuse the
> > dependency resolution. and the build may fail.
> >
> >
> > Patch "drivers: net: dsa: realtek: fix warning same module names" and
> > "drivers: net: phy: realtek: fix warning same module names" resolves the
> > name clatch realtek.ko.
> >
> > warning: same module names found:
> > drivers/net/phy/realtek.ko
> > drivers/net/dsa/realtek.ko
> >
> >
> > Patch "drivers: (video|gpu): fix warning same module names" resolves
> > the name clatch mxsfb.ko.
> >
> > warning: same module names found:
> > drivers/video/fbdev/mxsfb.ko
> > drivers/gpu/drm/mxsfb/mxsfb.ko
> >
> > Patch "drivers: media: i2c: fix warning same module names" resolves the
> > name clatch adv7511.ko however, it seams to refer to the same device
> > name in i2c_device_id, does anyone have any guidance how that should be
> > solved?
> >
> > warning: same module names found:
> > drivers/gpu/drm/bridge/adv7511/adv7511.ko
> > drivers/media/i2c/adv7511.ko
> >
> >
> > Patch "drivers: media: coda: fix warning same module names" resolves the
> > name clatch coda.ko.
> >
> > warning: same module names found:
> > fs/coda/coda.ko
> > drivers/media/platform/coda/coda.ko
>
> Media change look ok, and probably the other patches too, but the
> problem here is: who will apply it and when.
>
> The way you grouped the changes makes harder for subsystem maintainers
> to pick, as the same patch touches multiple subsystems.
>
> On the other hand, if this gets picked by someone else, it has the
> potential to cause conflicts between linux-next and the maintainer's
> tree.
>
> So, the best would be if you re-arrange this series to submit one
> patch per subsystem.

I will send it per subsystem.

Cheers,
Anders

>
>
> >
> >
> > Patch "drivers: net: phy: fix warning same module names" resolves the
> > name clatch asix.ko.
> >
> > warning: same module names found:
> > drivers/net/phy/asix.ko
> > drivers/net/usb/asix.ko
> >
> > Patch "drivers: mfd: 88pm800: fix warning same module names" and
> > "drivers: regulator: 88pm800: fix warning same module names" resolves
> > the name clatch 88pm800.ko.
> >
> > warning: same module names found:
> > drivers/regulator/88pm800.ko
> > drivers/mfd/88pm800.ko
> >
> >
> > Cheers,
> > Anders
> >
> > Anders Roxell (8):
> > drivers: net: dsa: realtek: fix warning same module names
> > drivers: net: phy: realtek: fix warning same module names
> > drivers: (video|gpu): fix warning same module names
> > drivers: media: i2c: fix warning same module names
> > drivers: media: coda: fix warning same module names
> > drivers: net: phy: fix warning same module names
> > drivers: mfd: 88pm800: fix warning same module names
> > drivers: regulator: 88pm800: fix warning same module names
> >
> > drivers/gpu/drm/bridge/adv7511/Makefile | 10 +++++-----
> > drivers/gpu/drm/mxsfb/Makefile | 4 ++--
> > drivers/media/i2c/Makefile | 3 ++-
> > drivers/media/platform/coda/Makefile | 4 ++--
> > drivers/mfd/Makefile | 7 +++++--
> > drivers/net/dsa/Makefile | 4 ++--
> > drivers/net/phy/Makefile | 6 ++++--
> > drivers/regulator/Makefile | 3 ++-
> > drivers/video/fbdev/Makefile | 3 ++-
> > 9 files changed, 26 insertions(+), 18 deletions(-)
> >
>
>
>
> Thanks,
> Mauro