Re: [PATCH 1/2] serial: xilinx_uartps: Fix warnings in the driver

From: Greg KH
Date: Mon Jun 10 2019 - 10:48:52 EST

On Mon, Jun 10, 2019 at 10:44:55AM +0200, Michal Simek wrote:
> From: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> This patch fixes the below warning
> -->Symbolic permissions 'S_IRUGO' are not preferred.
> Consider using octal permissions '0444'.
> -->macros should not use a trailing semicolon.
> -->line over 80 characters.
> -->void function return statements are not generally useful.
> -->Prefer 'unsigned int' to bare use of 'unsigned'.
> Signed-off-by: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> ---
> Happy to split it if needed.

Please split. Do not do more than one "logical thing" per patch.

And the subject is not correct, there are no general "warnings", these
are all checkpatch warnings, not a build issue.


greg k-h