RE: [PATCH net-next 1/2] hinic: add rss support

[Salil Mehta]

> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Xue Chaojing
> Sent: Monday, June 10, 2019 4:35 AM
> To: davem@xxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Luoshaokai
> (luoshaokai) <luoshaokai@xxxxxxxxxx>; Wangxiaoyun (Cloud, Network Chip
> Application Development Dept) <cloud.wangxiaoyun@xxxxxxxxxx>;
> xuechaojing <xuechaojing@xxxxxxxxxx>; chiqijun <chiqijun@xxxxxxxxxx>;
> wulike (A) <wulike1@xxxxxxxxxx>
> Subject: [PATCH net-next 1/2] hinic: add rss support
> 
> This patch adds rss support for the HINIC driver.
> 
> Signed-off-by: Xue Chaojing <xuechaojing@xxxxxxxxxx>
> ---

[...]

> +
> +int hinic_set_rss_type(struct hinic_dev *nic_dev, u32 tmpl_idx,
> +		       struct hinic_rss_type rss_type)
> +{
> +	struct hinic_hwdev *hwdev = nic_dev->hwdev;
> +	struct hinic_func_to_io *func_to_io = &hwdev->func_to_io;
> +	struct hinic_hwif *hwif = hwdev->hwif;
> +	struct hinic_rss_context_tbl *ctx_tbl;
> +	struct pci_dev *pdev = hwif->pdev;
> +	struct hinic_cmdq_buf cmd_buf;
> +	u64 out_param;
> +	u32 ctx = 0;
> +	int err;


reverse Christmas tree order in defining local variables everywhere?