Re: [PATCH 07/15] x86: Add int3_emulate_call() selftest

From: Andy Lutomirski
Date: Mon Jun 10 2019 - 13:02:37 EST


On Mon, Jun 10, 2019 at 9:53 AM Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
>
> On Wed, Jun 05, 2019 at 03:08:00PM +0200, Peter Zijlstra wrote:
> > Given that the entry_*.S changes for this functionality are somewhat
> > tricky, make sure the paths are tested every boot, instead of on the
> > rare occasion when we trip an INT3 while rewriting text.
> >
> > Requested-by: Andy Lutomirski <luto@xxxxxxxxxx>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>
> Reviewed-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
>

Looks good to me, too, except that I seriously hate die notifiers that
return NOTIFY_STOP, and I eventually want to remove support for them.
This can wait, though.