Re: çå: çå: çå: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.

[Pali RohÃr]

On Tuesday 11 June 2019 12:32:33 Hui Wang wrote:
> On 2019/6/11 äå11:23, Hui Wang wrote:
> > On 2019/6/11 äå11:05, Xiaoxiao Liu wrote:
> > > Hi Pali,
> > > 
> > > I discussed with our FW team about this problem.
> > > We think the V8 method means a touchpad feature and does not fit
> > > the CS19 trackpoint device.
> > > CS19 TrackPoint needn't use any Absolute (Raw) mode and is usually
> > > use standard mouse data.
> > > CS19 TrackPoint device is a completely different device with
> > > DualPoint device of Dell/HP.
> > > CS19 TrackPoint device is independent of Touchpad. (Touchpad is
> > > connecting by I2C, TrackPoint is directly connecting with PS2 port.)
> > > And it has completely another FW.
> > > 
> > > So we think it is better to use the mouse mode for CS19 trackpoint.
> > 
> > Maybe here is some mis-understanding, the mouse mode here doesn't mean
> > we use psmouse-base.c for cs19 (bare ps/2 mouse), we plan to use
> > trackpoint.c to drive this HW, so this trackpoint has all features a
> > trackpoint should have.
> > 
> And I sent a patch one month ago to let the the trackpoint.c to drive this
> HW: https://www.spinics.net/lists/linux-input/msg61341.html, maybe that
> patch is reference.

So instead of creating blacklist, you should check for TP_VARIANT_ALPS
in alps.c and disallow its usage.

Or maybe better, move trackpoint.c detect code before alsp.c detect code
in psmouse-base. And no changes in alps.c are needed.

> > Regards,
> > 
> > Hui.
> > 
> > > 
> > > Best Regards
> > > Shona
> > > -----éäåä-----
> > > åää: Pali RohÃr <pali.rohar@xxxxxxxxx>
> > > åéæé: Monday, June 10, 2019 6:43 PM
> > > æää: å ææ Xiaoxiao Liu <xiaoxiao.liu-1@xxxxxxxxxxx>
> > > æé: XiaoXiao Liu <sliuuxiaonxiao@xxxxxxxxx>;
> > > dmitry.torokhov@xxxxxxxxx; peter.hutterer@xxxxxxxxx;
> > > hui.wang@xxxxxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx;
> > > linux-kernel@xxxxxxxxxxxxxxx; æ æå Xiaojian Cao
> > > <xiaojian.cao@xxxxxxxxxxx>; zhangfp1@xxxxxxxxxx; æè çæ Naoki
> > > Saito <naoki.saito@xxxxxxxxxxxxxx>; åç èå Hideo Kawase
> > > <hideo.kawase@xxxxxxxxxxxxxx>
> > > äé: Re: çå: çå: [PATCH] input: alps-fix the issue alps cs19
> > > trackstick do not work.
> > > 
> > > On Monday 10 June 2019 10:03:51 Xiaoxiao Liu wrote:
> > > > Hi Pali,
> > > Hi!
> > > 
> > > > We register our CS19 device as ALPS_ONLY_TRACKSTICK device.
> > > > And let the V8 protocol function support the process of
> > > > ALPS_ONLY_TRACKSTICK device.
> > > > 
> > > > I want to confirm if this solution OK?
> > > Yes, it is fine. Just make sure that touchapad input device is not
> > > registered when this ALPS_ONLY_TRACKSTICK flag is set. So userspace
> > > would not see any fake/unavailable touchpad input device.
> > > 
> > > > Xiaoxiao.Liu
> > > -- 
> > > Pali RohÃr
> > > pali.rohar@xxxxxxxxx

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx