Re: [PATCH 15/15] riscv: add binfmt_flat support

From: Christoph Hellwig
Date: Tue Jun 11 2019 - 05:25:08 EST


On Tue, Jun 11, 2019 at 09:16:43AM +0100, Vladimir Murzin wrote:
> On 6/10/19 10:20 PM, Christoph Hellwig wrote:
> > Use the generic support with arguments are on the stack. Same as arm
> > and m68k.
>
> Out of curiosity, what is reason for keeping arguments on the stack?
>
> ARM port of uClibc has following comment around manipulating of argv/argc:
>
> /*
> * uClinux/arm stacks look a little different from normal
> * MMU-full Linux/arm stacks (for no good reason)
> */
>
> So I though it is kind of legacy.

I just copied m68k and arm. But dropping this makes the uclinux
crt1 code simpler, so I'll drop the flag for the next version.