Re: [PATCH 14/15] static_call: Simple self-test module

[Josh Poimboeuf]

On Tue, Jun 11, 2019 at 10:29:31AM +0200, Peter Zijlstra wrote:
> On Mon, Jun 10, 2019 at 12:24:28PM -0500, Josh Poimboeuf wrote:
> > On Wed, Jun 05, 2019 at 03:08:07PM +0200, Peter Zijlstra wrote:
> > > 
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> > > ---
> > >  lib/Kconfig.debug      |    8 ++++++++
> > >  lib/Makefile           |    1 +
> > >  lib/test_static_call.c |   41 +++++++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 50 insertions(+)
> > > 
> > > --- a/lib/Kconfig.debug
> > > +++ b/lib/Kconfig.debug
> > > @@ -1955,6 +1955,14 @@ config TEST_STATIC_KEYS
> > >  
> > >  	  If unsure, say N.
> > >  
> > > +config TEST_STATIC_CALL
> > > +	tristate "Test static call"
> > > +	depends on m
> > > +	help
> > > +	  Test the static call interfaces.
> > > +
> > > +	  If unsure, say N.
> > > +
> > 
> > Any reason why we wouldn't just make this a built-in boot time test?
> 
> None what so ever; but I did copy paste from the static_key stuff and
> that has it for some rasin.

Their functionality is pretty crucial, and I doubt anybody is manually
building and loading these tests?  Seems like built-in tests would be
wiser for both static calls/keys.

-- 
Josh