Re: [PATCH v4 0/8] arm64: IRQ priority masking and Pseudo-NMI fixes

[Marc Zyngier]

Hi Julien,

On 11/06/2019 10:38, Julien Thierry wrote:
> Hi,
> 
> Version one[1] of this series attempted to fix the issue reported by
> Zenghui[2] when using the function_graph tracer with IRQ priority
> masking.
> 
> Since then, I realized that priority masking and the use of Pseudo-NMIs
> was more broken than I thought.
> 
> * Patch 1-2 are just some cleanup
> * Patch 3 fixes a potential issue with not clobbering condition flags
>   in irqflags operations
> * Patch 4 fixes an issue where calling C code in Pseudo-NMI before
>   entering NMI enter could lead to potential races
> * Patch 5 fixes the function_graph issue when using priority masking
> * Patch 6 introduces some debug to hopefully avoid breaking things in
>   the future
> * Patch 7 is a rebased version of the patch sent by Wei Li[3] fixing
>   an error that can happen during on some platform using the priority
>   masking feature
> * Patch 8 re-enables the Pseudo-NMI selection
> 
> Changes since V3 [4]:
> - Rebase on v5.2-rc4
> - Fix comments/typos/missed updates
> - Use single condition evalution for nmi_enter and nmi_exit

Thanks for following up on this. For the whole series:

Reviewed-by: Marc Zyngier <marc.zyngier@xxxxxxx>

	M.
-- 
Jazz is not dead. It just smells funny...