Re: [PATCH] kbuild: Add -Werror=unknown-warning-option to CLANG_FLAGS

From: Nick Desaulniers
Date: Tue Jun 11 2019 - 15:42:20 EST


On Tue, Jun 11, 2019 at 11:43 AM Nathan Chancellor
<natechancellor@xxxxxxxxx> wrote:
> Suggested-by: Peter Smith <peter.smith@xxxxxxxxxx>
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

I verified this has no negative effect with -Qunused-arguments and the
relative position of the two flags. The build failure is much more
explicit with this patch:
> error: unknown warning option '-Wno-psabi' [-Werror,-Wunknown-warning-option]

Tested-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index b81e17261250..5f9d09bd2252 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -528,6 +528,7 @@ ifneq ($(GCC_TOOLCHAIN),)
> CLANG_FLAGS += --gcc-toolchain=$(GCC_TOOLCHAIN)
> endif
> CLANG_FLAGS += -no-integrated-as
> +CLANG_FLAGS += -Werror=unknown-warning-option
> KBUILD_CFLAGS += $(CLANG_FLAGS)
> KBUILD_AFLAGS += $(CLANG_FLAGS)
> export CLANG_FLAGS
> --
> 2.22.0
>


--
Thanks,
~Nick Desaulniers