Re: [PATCH] platform/x86: asus-wmi: Only Tell EC the OS will handle display hotkeys from asus_nb_wmi

[Hans de Goede]

Hi,

On 11-06-19 21:15, Andy Shevchenko wrote:
> On Wed, Jun 5, 2019 at 9:15 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > Hi,
> >
> > On 28-05-19 15:37, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 24-05-19 18:43, Andy Shevchenko wrote:
> > > > On Tue, May 21, 2019 at 9:28 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > > > > Commit 78f3ac76d9e5 ("platform/x86: asus-wmi: Tell the EC the OS will
> > > > > handle the display off hotkey") causes the backlight to be permanently off
> > > > > on various EeePC laptop models using the eeepc-wmi driver (Asus EeePC
> > > > > 1015BX, Asus EeePC 1025C).
> > > > >
> > > > > The asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL) call added
> > > > > by that commit is made conditional in this commit and only enabled in
> > > > > the quirk_entry structs in the asus-nb-wmi driver fixing the broken
> > > > > display / backlight on various EeePC laptop models.
> > > >
> > > > Hmm... doesn't apply.
> > >
> > > That is likely because your review-andy branch contain a whole-bunch
> > > of asus-wmi patches.
> > >
> > > Since this is a patch fixing a regression this should go to the fixes
> > > branch. As the other patches so far are only in your review-andy branch
> > > it is probably best to merge this patch to for-next + fixes first and
> > > then rebase the set you have in review-andy on top, so that this can go
> > > to fixes without getting a merge conflict when the rest of the patches
> > > show up...
> >
> > Ping? This is a 5.x regression fix, as such it would be really good to
> > get this into 5.2 and then cherry-picked into 5.y.z.
>
> It doesn't apply to our fixes branch.

Weird. I will resend the patch rebased on top of 5.2-rc4.

Regards,

Hans