Re: linux-next: build warning after merge of the i2c tree
From: Wolfram Sang
Date: Wed Jun 12 2019 - 07:13:43 EST
Hi Mauro,
> That entire use of _P, _R and _ri looks weird into my eyes. The code there
Yes.
> do things like:
>
> #define _P 32
>
> ...
>
> if (_P == 64)
> reg1[1] |= 0x40;
Yup, I saw this, too, but didn't feel like refactoring the driver.
Thanks for stepping up!
> I'll work on a patch to address it.
OK, so that means I should send my pull request after yours in the next
merge window? To avoid the build breakage?
Kind regards,
Wolfram
Attachment:
signature.asc
Description: PGP signature