Re: [PATCH v4 3/3] livepatch: Remove duplicate warning about missing reliable stacktrace support

From: Kamalesh Babulal
Date: Wed Jun 12 2019 - 09:57:15 EST


On Tue, Jun 11, 2019 at 04:13:20PM +0200, Miroslav Benes wrote:
> From: Petr Mladek <pmladek@xxxxxxxx>
>
> WARN_ON_ONCE() could not be called safely under rq lock because
> of console deadlock issues. Moreover WARN_ON_ONCE() is superfluous in
> klp_check_stack(), because stack_trace_save_tsk_reliable() cannot return
> -ENOSYS thanks to klp_have_reliable_stack() check in
> klp_try_switch_task().
>
> Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>
> [ mbenes: changelog edited ]
> Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>

Reviewed-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx>