Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

[Arend Van Spriel]

On 6/12/2019 1:48 PM, Ulf Hansson wrote:
> On Wed, 12 Jun 2019 at 13:11, Arend Van Spriel
> <arend.vanspriel@xxxxxxxxxxxx> wrote:
> > On 6/12/2019 12:10 PM, Ulf Hansson wrote:
> > > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:
> > > >     mmc_set_data_timeout(md, func->card);
> > > >     mmc_wait_for_req(func->card->host, mr);
> > > These are not okay, none of these things calls should really be done
> > > from an SDIO func driver.
> > >
> > > It tells me that the func driver is a doing workaround for something
> > > that should be managed in a common way.
> >
> > We are using some low-level functions passing chain of skbuff to the
> > device using CMD53 with scatterlist. If I recall correctly Marvell made
> > an attempt to have a similar function for it in the mmc stack. Not sure
> > if that ever made it in. If so I can rework our driver using that API.
> > If not, I can make a new attempt.
>
> I recall there were some patches, but not sure why we didn't merge them.
>
> Anyway, if you want to move this forward, that would be awesome!

Let's scope it before moving forward. Our use-case is to transfer a
chain of skbuff's. I am pretty sure that is not something we want to
deal with in mmc stack api. So I suppose passing a scatterlist is more
sensible, right? Maybe on sdio layer of the stack we could consider
dealing with skbuff's for network func drivers?

Let me see if I can find those Marvell patches. Might be a good start.

Regards,
Arend