Re: [PATCH v15 0/3] Add support for the Purism Librem5 devkit

[Angus Ainslie]

Hi Pavel,

On 2019-06-10 07:52, Pavel Machek wrote:
> On Wed 2019-06-05 06:48:05, Angus Ainslie wrote:
> > On 2019-06-05 03:03, Shawn Guo wrote:
> > >On Tue, May 28, 2019 at 05:57:44AM -0700, Angus Ainslie (Purism) wrote:
> > >>The Librem5 devkit is based on the imx8mq from NXP. This is a default
> > >>devicetree to boot the board to a command prompt.
> > >>
> > >>Changes since v14:
> > >>
> > >>Add regulator-always-on for the SNVS regulators.
> > >>Added pgc nodes.
> > >>Fixed charger pre-current.
> > >
> > >Since Pavel was reviewing your patches, you should copy him on the new
> > >version.  Has this version addressed all his review comments?
> > >
> >
> > Sorry I had meant to include him in the CC.
> >
> > I believe so but don't want to speak for him so we should see if he
> > has anymore.
>
> I did not check the code, sorry.
>
> I still believe your shutdown voltage is too low; try that. Battery
> will go down from 3V
> to 2.8V in seconds, so you don't really gain anything by using lower
> threshold, and you
> may not even have enough time to shutdown the system if you set it too 
> low.
>
> Normally something like 3.0V, 3.2V is reasonable shutdown voltage.

I took another look at the BQ25896 datasheet and the minimum-sys-voltage 
register is limited to 3.0-3.7 V.

I'll submit a new version.

Angus

> Best regards,
> 										Pavel