Re: [PATCH 12/21] EDAC, ghes: Add support for legacy API counters

[Robert Richter]

On 29.05.19 16:13:02, James Morse wrote:
> On 29/05/2019 09:44, Robert Richter wrote:
> > The ghes driver is not able yet to count legacy API counters in sysfs,
> > e.g.:
> > 
> >  /sys/devices/system/edac/mc/mc0/csrow2/ce_count
> >  /sys/devices/system/edac/mc/mc0/csrow2/ch0_ce_count
> >  /sys/devices/system/edac/mc/mc0/csrow2/ch1_ce_count
> > 
> > Make counting csrows/channels generic so that the ghes driver can use
> > it too.
> 
> What for?

With EDAC_LEGACY_SYSFS enabled those counters are exposed to sysfs,
but the numbers are wrong (all zero).

> Is this for an arm64 system? Surely we don't have any systems that used to work with these
> legacy counters. Aren't they legacy because we want new software to stop using them!

The option is to support legacy userland. If we want to provide a
similar "user experience" as for x86 the counters should be correct.
Of course it is not a real mapping to csrows, but it makes that i/f
work.

In any case, this patch cleans up code as old API's counter code is
isolated and moved to common code. Making the counter's work for ghes
is actually a side-effect here. The cleanup is a prerequisit for
follow on patches.

-Robert

> 
> 
> Thanks,
> 
> James