Re: [PATCH 02/19] btrfs: Get zone information of zoned block devices
From: Josef Bacik
Date: Thu Jun 13 2019 - 11:14:08 EST
On Fri, Jun 07, 2019 at 10:10:08PM +0900, Naohiro Aota wrote:
> If a zoned block device is found, get its zone information (number of zones
> and zone size) using the new helper function btrfs_get_dev_zonetypes(). To
> avoid costly run-time zone report commands to test the device zones type
> during block allocation, attach the seqzones bitmap to the device structure
> to indicate if a zone is sequential or accept random writes.
>
> This patch also introduces the helper function btrfs_dev_is_sequential() to
> test if the zone storing a block is a sequential write required zone.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxx>
> Signed-off-by: Naohiro Aota <naohiro.aota@xxxxxxx>
> ---
> fs/btrfs/volumes.c | 143 +++++++++++++++++++++++++++++++++++++++++++++
> fs/btrfs/volumes.h | 33 +++++++++++
> 2 files changed, 176 insertions(+)
>
We have enough problems with giant files already, please just add a separate
hmzoned.c or whatever and put all the zone specific code in there. That'll save
me time when I go and break a bunch of stuff out. Thanks,
Josef