Re: [PATCH] mm/vmalloc: Check absolute error return from vmap_[p4d|pud|pmd|pte]_range()

From: Matthew Wilcox
Date: Thu Jun 13 2019 - 11:36:26 EST


On Thu, Jun 13, 2019 at 08:51:17PM +0530, Anshuman Khandual wrote:
> acceptable ? What we have currently is wrong where vmap_pmd_range() could
> just wrap EBUSY as ENOMEM and send up the call chain.

It's not wrong. We do it in lots of places. Unless there's a caller
which really needs to know the difference, it's often better than
returning the "real error".