Re: [PATCH 14/34] misc: tsl2550: simplify getting the adapter of a client

From: Simon Horman
Date: Thu Jun 13 2019 - 11:46:35 EST


On Sat, Jun 08, 2019 at 12:55:53PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>


Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

> ---
>
> Please apply to your subsystem tree.
>
> drivers/misc/tsl2550.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c
> index 5b7afd6190fe..09db397df287 100644
> --- a/drivers/misc/tsl2550.c
> +++ b/drivers/misc/tsl2550.c
> @@ -336,7 +336,7 @@ static struct i2c_driver tsl2550_driver;
> static int tsl2550_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
> + struct i2c_adapter *adapter = client->adapter;
> struct tsl2550_data *data;
> int *opmode, err = 0;
>
> --
> 2.19.1
>