Re: [PATCH] fault-inject: clean up debugfs file creation logic

From: Akinobu Mita
Date: Thu Jun 13 2019 - 12:29:41 EST


2019å6æ12æ(æ) 18:58 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>:
>
> There is no need to check the return value of a debugfs_create_file
> call, a caller should never change what they do depending on if debugfs
> is working properly or not, so remove the checks, simplifying the logic
> in the file a lot.
>
> Also fix up the error check for debugfs_create_dir() which was not
> returning NULL for an error, but rather a error pointer.
>
> Cc: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Looks good.

Reviewed-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>