Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook

From: Benjamin Herrenschmidt
Date: Thu Jun 13 2019 - 13:18:46 EST


On Wed, 2019-06-12 at 14:41 -0500, Larry Finger wrote:
> On 6/12/19 1:55 AM, Christoph Hellwig wrote:
> >
> > Ooops, yes. But I think we could just enable ZONE_DMA on 32-bit
> > powerpc. Crude enablement hack below:
> >
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index 8c1c636308c8..1dd71a98b70c 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -372,7 +372,7 @@ config PPC_ADV_DEBUG_DAC_RANGE
> >
> > config ZONE_DMA
> > bool
> > - default y if PPC_BOOK3E_64
> > + default y
> >
> > config PGTABLE_LEVELS
> > int
> >
>
> With the patch for Kconfig above, and the original patch setting
> ARCH_ZONE_DMA_BITS to 30, everything works.
>
> Do you have any ideas on what should trigger the change in ARCH_ZONE_BITS?
> Should it be CONFIG_PPC32 defined, or perhaps CONFIG_G4_CPU defined?

I think CONFIG_PPC32 is fine

Ben.