Re: [PATCH V8 3/3] Call ima_kexec_cmdline to measure the cmdline args

From: Mimi Zohar
Date: Thu Jun 13 2019 - 16:25:06 EST


On Wed, 2019-06-12 at 15:15 -0700, Prakhar Srivastava wrote:
> During soft reboot(kexec_file_load) boot cmdline args

Any reason for not spelling it out and using the "boot command line"?

> are not measured.Thus the new kernel on load boots with
> an assumption of cold reboot.

Double spaces after a period.

What does "boots with an assumption of cold reboot" mean? ÂNot all
systems are booted the same way. ÂIs this comment relevant?

>
> This patch makes a call to the ima hook ima_kexec_cmdline,
> added in "Define a new IMA hook to measure the boot command
> line arguments"

"added in ..." is unnecessry.

> to measure the boot cmdline args into the ima log.

^IMA measurement list.

Mimi