Re: [linux-sunxi] [PATCH 2/9] drm/sun4i: tcon: Add TCON LCD support for R40

[Chen-Yu Tsai]

On Fri, Jun 14, 2019 at 11:19 AM Chen-Yu Tsai <wens@xxxxxxxx> wrote:
>
> On Fri, Jun 14, 2019 at 2:53 AM Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > TCON LCD0, LCD1 in allwinner R40, are used for managing
> > LCD interfaces like RGB, LVDS and DSI.
> >
> > Like TCON TV0, TV1 these LCD0, LCD1 are also managed via
> > tcon top.
> >
> > Add support for it, in tcon driver.
> >
> > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>

I take that back.

The TCON output muxing (which selects whether TCON LCD or TCON TV
outputs to the GPIO pins)
is not supported yet. Please at least add TODO notes, or ideally,
block RGB output from
being used.

ChenYu