[PATCH] af_key: Fix memory leak in key_notify_policy.

From: Young Xiao
Date: Fri Jun 14 2019 - 04:30:02 EST


We leak the allocated out_skb in case pfkey_xfrm_policy2msg() fails.
Fix this by freeing it on error.

Signed-off-by: Young Xiao <92siuyang@xxxxxxxxx>
---
net/key/af_key.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/key/af_key.c b/net/key/af_key.c
index 4af1e1d..ec414f6 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -2443,6 +2443,7 @@ static int key_pol_get_resp(struct sock *sk, struct xfrm_policy *xp, const struc
}
err = pfkey_xfrm_policy2msg(out_skb, xp, dir);
if (err < 0)
+ kfree_skb(out_skb);
goto out;

out_hdr = (struct sadb_msg *) out_skb->data;
@@ -2695,6 +2696,7 @@ static int dump_sp(struct xfrm_policy *xp, int dir, int count, void *ptr)

err = pfkey_xfrm_policy2msg(out_skb, xp, dir);
if (err < 0)
+ kfree_skb(out_skb);
return err;

out_hdr = (struct sadb_msg *) out_skb->data;
--
2.7.4