Re: [PATCH v5 01/10] media: dt-bindings: marvell,mmp2-ccic: Add Marvell MMP2 camera

[Jacopo Mondi]

Hi Lubomir,

On Sun, May 05, 2019 at 04:00:22PM +0200, Lubomir Rintel wrote:
> Add Marvell MMP2 camera host interface.
>
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
>
> ---
> Changes since v4:
> - s/Nust/Must/
> - Documented required endpoint properties; bus-type, hsync-active,
>   vsync-active and pclk-sample.
>
> Changes since v3:
> - Dropped the video-interfaces.txt reference
> - Clarify "clocks", "clock-names" and "clock-output-names" descriptions
> - Refer to other documentation by full path
>
> Changes since v2:
> - Added #clock-cells, clock-names, port
>
>  .../bindings/media/marvell,mmp2-ccic.txt      | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
>
> diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> new file mode 100644
> index 0000000000000..7ec2c8c8a3b98
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> @@ -0,0 +1,50 @@
> +Marvell MMP2 camera host interface
> +
> +Required properties:
> + - compatible: Should be "marvell,mmp2-ccic".
> + - reg: Register base and size.
> + - interrupts: The interrupt number.
> + - #clock-cells: Must be 0.
> +
> +Optional properties:
> + - clocks: Reference to the input clock as specified by
> +           Documentation/devicetree/bindings/clock/clock-bindings.txt.
> + - clock-names: Names of the clocks used; "axi" for the AXI bus interface,
> +                "func" for the peripheral clock and "phy" for the parallel
> +                video bus interface.
> + - clock-output-names: Optional clock source for sensors. Shall be "mclk".
> +
> +Required subnodes:
> + - port: The parallel bus interface port with a single endpoint linked to
> +         the sensor's endpoint as described in
> +         Documentation/devicetree/bindings/media/video-interfaces.txt.
> +
> +Required endpoint properties:
> + - bus-type: data bus type, <5> or <6> for Parallel or Bt.656 respectively
> + - pclk-sample: pixel clock polarity
> + - hsync-active: horizontal synchronization polarity (only required for
> +   parallel bus)
> + - vsync-active: vertical synchronization polarity (only required for
> +   parallel bus)

Minor nit: if you don't want to specify what maps to 0/1 in the
properties, could you add "as defined in video-interfaces.txt" after
each property?

Reviewed-by: Jacopo Mondi <jacopo@xxxxxxxxxx>

Thanks
  j

> +
> +Example:
> +
> +	camera0: camera@d420a000 {
> +		compatible = "marvell,mmp2-ccic";
> +		reg = <0xd420a000 0x800>;
> +		interrupts = <42>;
> +		clocks = <&soc_clocks MMP2_CLK_CCIC0>;
> +		clock-names = "axi";
> +		#clock-cells = <0>;
> +		clock-output-names = "mclk";
> +
> +		port {
> +			camera0_0: endpoint {
> +				remote-endpoint = <&ov7670_0>;
> +                                bus-type = <5>;      /* Parallel */
> +                                hsync-active = <1>;  /* Active high */
> +                                vsync-active = <1>;  /* Active high */
> +                                pclk-sample = <0>;   /* Falling */
> +			};
> +		};
> +	};
> --
> 2.21.0
>

Attachment: signature.asc
Description: PGP signature