Re: [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling

From: Mika Westerberg
Date: Fri Jun 14 2019 - 06:50:08 EST


On Thu, Jun 13, 2019 at 10:24:41PM +0200, Rafael J. Wysocki wrote:
> This patch may cause events to be missed if the GPE. I guess what you reall mean is
> something like the patch below.
>
> This should allow the kernel to see the events generated before the GPEs are
> implicitly enabled, but it should clear them for the explicit users of acpi_enable_gpe().
>
> Mika, what do you think?

Looks good to me. I also tested this with two TBT systems (Skull Canyon
NUC and Dell XPS 9370) using ACPI hotplug and it did not cause any
problems if I boot the system with device connected.