Re: [PATCHv2 0/8] perf/x86: Rework msr probe interface

From: Peter Zijlstra
Date: Fri Jun 14 2019 - 08:42:10 EST


On Fri, Jun 14, 2019 at 12:20:46PM +0200, Jiri Olsa wrote:
> On Fri, May 31, 2019 at 02:09:50PM +0200, Jiri Olsa wrote:
> > hi,
> > following up on [1], [2] and [3], this patchset adds update
> > attribute groups to pmu, factors out the MSR probe code and
> > use it in msr,cstate* and rapl PMUs.
> >
> > The functionality stays the same with one exception:
> > for msr PMU: the event is not exported if the rdmsr return zero
> > on event's msr, cstate* and rapl pmu functionality stays.
> >
> > And also: ;-)
> > > Somewhere along the line you lost the explanation of _why_ we're doing
> > > this; namely: virt sucks.
> >
> > Also available in:
> > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> > perf/msr
> >
> > Tested on snb and skylake servers.
> >
> > v2 changes:
> > - checking zero rdmsr only for msr PMU events,
> > cstate* and rapl pmu functionality stays unchanged
>
> ping

I was waiting a new post because you mentioned something about some
people not being happy with this, something about a wonky BIOS failing
this on native.