Re: [PATCH] perf vendor events: Add Icelake V1.00 event file

[Liang, Kan]

On 6/13/2019 9:48 PM, Haiyan Song wrote:
> diff --git a/tools/perf/pmu-events/arch/x86/mapfile.csv b/tools/perf/pmu-events/arch/x86/mapfile.csv
> index d6984a3017e0..f8357a79641a 100644
> --- a/tools/perf/pmu-events/arch/x86/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/x86/mapfile.csv
> @@ -33,4 +33,5 @@ GenuineIntel-6-25,v2,westmereep-sp,core
>   GenuineIntel-6-2F,v2,westmereex,core
>   GenuineIntel-6-55-[01234],v1,skylakex,core
>   GenuineIntel-6-55-[56789ABCDEF],v1,cascadelakex,core
> +GenuineIntel-6-7E,v1,icelake,core
>   AuthenticAMD-23-[[:xdigit:]]+,v1,amdfam17h,core

Hi Haiyan,

I forgot to mention that we just added more Ice Lake model number.
You may want to add the support for Ice Lake Desktop as well.

    GenuineIntel-6-7D,v1,icelake,core

The rest looks good to me.

Thanks,
Kan