Re: [PATCH v2 4/6] clocksource/drivers/tegra: Drop unneeded typecasting in one place

From: Jon Hunter
Date: Fri Jun 14 2019 - 11:53:32 EST



On 10/06/2019 17:43, Dmitry Osipenko wrote:
> There is no need to cast void because kernel allows to do that without
> a warning message from a compiler.
>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
> drivers/clocksource/timer-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-tegra.c b/drivers/clocksource/timer-tegra.c
> index 646b3530c2d2..a7fa12488066 100644
> --- a/drivers/clocksource/timer-tegra.c
> +++ b/drivers/clocksource/timer-tegra.c
> @@ -81,7 +81,7 @@ static int tegra_timer_set_periodic(struct clock_event_device *evt)
>
> static irqreturn_t tegra_timer_isr(int irq, void *dev_id)
> {
> - struct clock_event_device *evt = (struct clock_event_device *)dev_id;
> + struct clock_event_device *evt = dev_id;
> void __iomem *reg_base = timer_of_base(to_timer_of(evt));
>
> writel_relaxed(TIMER_PCR_INTR_CLR, reg_base + TIMER_PCR);

Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Cheers
Jon

--
nvpublic